Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2020-02-01-preview for Media Services LVA #8281

Merged
merged 11 commits into from
Feb 24, 2020
Merged

2020-02-01-preview for Media Services LVA #8281

merged 11 commits into from
Feb 24, 2020

Conversation

microsoft-rin
Copy link
Contributor

@microsoft-rin microsoft-rin commented Feb 1, 2020 •
edited
Loading

Changes to MediaGraph model
Changing PUT from sync to async
Fixing some description

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@microsoft-rin
2020-02-01-preview for Media Services LVA
ff91d1c 
Changes to MediaGraph model
Changing PUT from sync to async
Fixing some description
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 1, 2020 •
edited
Loading

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 02b1e31 with merge commit 77fa990. SDK Automation 13.0.17.20191226.1 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 1, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 1, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Feb 1, 2020
Closed
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 1, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 02b1e31 with merge commit 77fa990. SDK Automation 13.0.17.20191226.1
  • ️✔️@azure/arm-mediaservices [Logs]  [Release SDK Changes] 
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/azureMediaServices.js → ./dist/arm-mediaservices.js...
[npmPack] created ./dist/arm-mediaservices.js in 731ms

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 1, 2020 •
edited
Loading

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

This was referenced Feb 1, 2020
Closed
Closed
Closed
Closed
Closed
Closed
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lirenhe lirenhe added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Feb 3, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 4, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@allenjzhang allenjzhang removed the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Feb 9, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-rin
Copy link
Contributor Author

microsoft-rin commented Feb 13, 2020 •
edited
Loading

Hi @pilor @allenjzhang @lirenhe , after some internal discussion within our team after the review meeting, we've decided to hold off the changes to async PUT, and just release the changes of adding a few new properties for media graph entity (our main ARM entity).

As suggested by @pilor , we uploaded the previous API version to commit 8 for easier review. So please compare the latest iteration with that commit as below screenshot.

image

@majastrz majastrz added ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Feb 14, 2020
@majastrz
Copy link
Member

Reset labels due to changes. Reviewing...

ravbhatnagar
ravbhatnagar reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off from ARM side

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 20, 2020
@allenjzhang allenjzhang self-requested a review February 24, 2020 19:41
@allenjzhang allenjzhang merged commit 77fa990 into Azure:master Feb 24, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@microsoft-rin @00Kai0
2020-02-01-preview for Media Services LVA (Azure#8281)
b17f322 
* 2020-02-01-preview for Media Services LVA

Changes to MediaGraph model
Changing PUT from sync to async
Fixing some description

* Prettier and model validations fix

* Fixing validations

* Fixing version in Common.json

* Using common types.json

* Updating new version

* Adding old version

* Revert "Adding old version"

This reverts commit 6bf3a73.

* Using common types

* Using 200 for operation locatio header.

* Fixing validation errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravbhatnagar ravbhatnagar ravbhatnagar left review comments

@lirenhe lirenhe lirenhe left review comments

@majastrz majastrz majastrz left review comments

@allenjzhang allenjzhang allenjzhang approved these changes

Assignees

@allenjzhang allenjzhang

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@microsoft-rin @allenjzhang @majastrz @ravbhatnagar @lirenhe @pilor